Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable ORC for nimble #1074

Merged
merged 7 commits into from
Nov 13, 2023
Merged

enable ORC for nimble #1074

merged 7 commits into from
Nov 13, 2023

Conversation

ringabout
Copy link
Member

Reverts #1041

@ringabout ringabout marked this pull request as draft February 27, 2023 11:11
ringabout
ringabout commented Feb 27, 2023
View reviewed changes
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
src/nimblepkg/topologicalsort.nim Outdated Show resolved Hide resolved
tests/tmisctests.nim Outdated Show resolved Hide resolved
tests/tmisctests.nim Outdated Show resolved Hide resolved
@ringabout ringabout closed this Nov 2, 2023
@ringabout ringabout reopened this Nov 2, 2023
@ringabout ringabout changed the title test ORC enable ORC for nimble Nov 6, 2023
@ringabout ringabout marked this pull request as ready for review November 6, 2023 10:57
@ringabout
Copy link
Member Author

ringabout commented Nov 6, 2023 •
edited
Loading

Finally, nimble passes ORC tests! Time to ship ORC-booting nimble => nim-lang/Nim#20780 for the devel branch (version-2-0 might not have included the proper fix; but we will see after 2.0.2 is released)

@ringabout ringabout requested a review from Araq November 13, 2023 11:08
@ringabout ringabout mentioned this pull request Nov 13, 2023
Closed
@ringabout ringabout marked this pull request as draft November 13, 2023 11:12
@ringabout ringabout removed the request for review from Araq November 13, 2023 11:13
@ringabout ringabout marked this pull request as ready for review November 13, 2023 12:39
@ringabout ringabout merged commit 9f3c808 into master Nov 13, 2023
6 checks passed
@ringabout ringabout deleted the revert-1041-patch-1 branch November 13, 2023 13:41
@ringabout ringabout mentioned this pull request Nov 23, 2023
Merged
Araq pushed a commit to nim-lang/Nim that referenced this pull request Nov 24, 2023
@ringabout
build nimble with ORC and bump nimble version (#22978)
816ddd8 
ref nim-lang/nimble#1074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Mergable if CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ringabout @Araq