Only caches nim release for a day (#1326)

nim-lang · Jan 1, 2025 · 5d4d8db · 5d4d8db
1 parent 920793e
commit 5d4d8db
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/nimblepkg/downloadnim.nim b/src/nimblepkg/downloadnim.nim
@@ -546,7 +546,10 @@ proc getOfficialReleases*(options: Options): seq[Version] =
   let oficialReleasesCachedFile =
     options.nimbleDir.absolutePath() / "official-nim-releases.json"
   if oficialReleasesCachedFile.fileExists():
-    return oficialReleasesCachedFile.readFile().parseJson().to(seq[Version])
+    #We only store the file for a day. 
+    let fileCreation = getTime() - getFileInfo(oficialReleasesCachedFile).lastWriteTime
+    if fileCreation.inDays <= 1:
+      return oficialReleasesCachedFile.readFile().parseJson().to(seq[Version])
   var parsedContents: JsonNode
   try:
     let rawContents = retrieveUrl(githubTagReleasesUrl.addGithubAuthentication())

diff --git a/tests/tnimbinaries.nim b/tests/tnimbinaries.nim
@@ -10,7 +10,6 @@ suite "Nim binaries":
     var options = initOptions()
     let releases = getOfficialReleases(options)
     check releases.len > 0
-    check releases[^1] == newVersion("1.2.8")
 
   test "can download a concrete version":
     var options = initOptions()