Simplify test task & possibly fix 32 bit #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test task now iterates over an array of backends to check and an array of files to test. I also turned off the hints, because I found them annoying. On the other hand, it now prints the backend currently being tested.
I changed an
intincalcSizes(that would overflow on 32 bit platforms) to anint64. As far as I can tell, this was the onlyintpossibly overflowing, so perhaps this library now works on 32 bit platforms (refs #48). It would be good if someone could run the tests on a 32 bit machine (I unfortunately don't have access to one and it doesn't seem like GitHub actions have either), perhaps @def- (since you originally reported tests failing on 32 bit platforms)?