Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tests/tliterals for automated testing #127

Closed
wants to merge 1 commit into from

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Jun 19, 2023

No description provided.

@dlesnoff
Copy link
Contributor

Please provide a description even if you use the Github CLI.

I do not get how this change enables «automated testing». We removed this file from the nimble task test for a good reason. All the files in the directory are prefixed with a t, to prevent naming conflicts/confusion (there can be only one bigints.nim file for example).

@ehmry ehmry closed this Jun 19, 2023
@pietroppeter
Copy link
Contributor

my guess about this is that the concern was about using command the predefined nimble test task: https://github.com/nim-lang/nimble#tests that would run all files in tests that start with t. This is not a concern for this repo since task test is overwritten.

@dlesnoff
Copy link
Contributor

Superseded by #128.

@ehmry ehmry mentioned this pull request Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants