refactor: address review feedback

niktverd · Jul 20, 2021 · 48a661e · 48a661e
1 parent b3446a1
commit 48a661e
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 11 deletions.
diff --git a/src/components/DocLeadingPage/DocLeadingPage.scss b/src/components/DocLeadingPage/DocLeadingPage.scss
@@ -42,7 +42,7 @@
         &_root {
             flex-direction: row;
             margin-top: 70px;
-            margin-bottom: -20px;
+            margin-bottom: -$blockMarginBottomLarge;
         }
     }
 
@@ -57,7 +57,7 @@
             max-width: 400px;
             width: calc(50% - 20px);
             padding-bottom: 40px;
-            margin-bottom: 20px;
+            margin-bottom: $blockMarginBottomLarge;
             border-bottom: 1px solid var(--yc-color-line-generic);
         }
     }

diff --git a/src/components/DocLeadingPage/DocLeadingPage.tsx b/src/components/DocLeadingPage/DocLeadingPage.tsx
@@ -46,13 +46,19 @@ const renderLeft = (data: DocLeadingLinks, isRoot?: boolean) => {
 
 const renderRight = (data: DocLeadingLinks, isRoot?: boolean) => {
     const {title, description, href, links} = data;
+    let titleContent;
 
-    let titleContent = href
-        ? <a href={href} className={b('links-link')}>{title}</a>
-        : title;
-    titleContent = isRoot
-        ? <h2 className={b('links-title', {root: isRoot})}>{titleContent}</h2>
-        : <div className={b('links-title')}>{titleContent}</div>;
+    if (href) {
+        titleContent = <a href={href} className={b('links-link')}>{title}</a>;
+    } else {
+        titleContent = title;
+    }
+
+    if (isRoot) {
+        titleContent = <h2 className={b('links-title', {root: isRoot})}>{titleContent}</h2>;
+    } else {
+        titleContent = <div className={b('links-title')}>{titleContent}</div>;
+    }
 
 
     return (

diff --git a/src/demo/Components/DocLeadingPage/index.tsx b/src/demo/Components/DocLeadingPage/index.tsx
@@ -1,8 +1,6 @@
 import React, {useState} from 'react';
 import cn from 'bem-cn-lite';
-import {
-    DocLeadingPage,
-} from '../../../index';
+import {DocLeadingPage} from '../../../index';
 import Header from '../Header/Header';
 import {DEFAULT_SETTINGS} from '../../../constants';
 import {getIsMobile} from '../../controls/settings';