Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Add response,status,xhr,form,dialog params to dialog2.ajax-complete. Fix extra spaces in lines. #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chronossc
Copy link

Hello, with that patch I made dialog2.ajax-complete event usefull. With that params I can have much more control over ajax process.

@nikku
Copy link
Owner

nikku commented Aug 20, 2012

Yes. Could you please update your pull request? To remove these additional changes?

@chronossc
Copy link
Author

I'm out of time, but I'll fix this week, probably in weekend.

@chronossc
Copy link
Author

Lines 45 to 47 in commit.

chronossc@cbd1bfb#L0R45

@chronossc
Copy link
Author

Ahn, @nikku, maybe is a nice opportunity to think what events should send response, or loaded content, etc, and also change this ones.

Also, a note about sending dialog to event, I did it because I can't close dialog in other way.

If we need to access dialog from any event how we do it without send dialog as argument to binded function?

@nikku nikku added the backlog label Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants