Fix exception raised from template should not show compiled code

nikhilbhatt · May 20, 2024 · 575c641 · 575c641
1 parent 965b8c3
commit 575c641
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/activesupport/lib/active_support/core_ext/erb/util.rb b/activesupport/lib/active_support/core_ext/erb/util.rb
@@ -188,6 +188,11 @@ def self.tokenize(source) # :nodoc:
         else
           raise NotImplementedError, source.matched
         end
+
+        unless source.eos? || source.exist?(start_re) || source.exist?(finish_re)
+          tokens << [:TEXT, source.rest]
+          source.terminate
+        end
       end
 
       tokens

diff --git a/activesupport/test/core_ext/erb_util_test.rb b/activesupport/test/core_ext/erb_util_test.rb
@@ -125,6 +125,16 @@ def test_no_end
       ], actual_tokens
     end
 
+    def test_text_end
+      source = "<%= @post.title %>   "
+      actual_tokens = tokenize source
+      assert_equal [[:OPEN, "<%="],
+                    [:CODE, " @post.title "],
+                    [:CLOSE, "%>"],
+                    [:TEXT, "   "],
+      ], actual_tokens
+    end
+
     def tokenize(source)
       ERB::Util.tokenize source
     end