Skip to content
This repository has been archived by the owner on Feb 25, 2018. It is now read-only.

Miscellaneous fixes #12

Open
wants to merge 4 commits into
base: development
Choose a base branch
from
Open

Miscellaneous fixes #12

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b18cd0f
Added function to check if item is visible
fabiocorneti Aug 12, 2017
72e72a8
Ignore invisible items when finding children
fabiocorneti Aug 12, 2017
6890882
Ignore invisible items when looking for first item in serial projects
fabiocorneti Aug 12, 2017
88ac793
Do not set next action in nested serial items if the project is seria…
fabiocorneti Aug 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 32 additions & 4 deletions nextaction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@
from datetime import datetime


def is_item_visible(item):
"""Returns true if the item is visible."""
for attr in ['is_deleted', 'is_archived', 'in_history', 'checked']:
if item[attr] == 1:
return False
return True


def get_subitems(items, parent_item=None):
"""Search a flat item list for child items."""
result_items = []
Expand All @@ -20,6 +28,8 @@ def get_subitems(items, parent_item=None):
else:
required_indent = 1
for item in items:
if not is_item_visible(item):
continue
if parent_item:
if not found and item['id'] != parent_item['id']:
continue
Expand Down Expand Up @@ -131,14 +141,22 @@ def remove_label(item, label):
# Get all items for the project, sort by the item_order field.
items = sorted(api.items.all(lambda x: x['project_id'] == project['id']), key=lambda x: x['item_order'])

# Tracks whether the first visible item at the root of the project has been found.
root_first_found = False
project_has_next_action = False

for item in items:

if not is_item_visible(item):
continue

# If its too far in the future, remove the next_action tag and skip
if args.hide_future > 0 and 'due_date_utc' in item.data and item['due_date_utc'] is not None:
due_date = datetime.strptime(item['due_date_utc'], '%a %d %b %Y %H:%M:%S +0000')
future_diff = (due_date - datetime.utcnow()).total_seconds()
if future_diff >= (args.hide_future * 86400):
remove_label(item, label_id)
root_first_found = True
continue

item_type = get_item_type(item)
Expand All @@ -147,12 +165,19 @@ def remove_label(item, label):
logging.debug('Identified %s as %s type', item['content'], item_type)

if item_type or len(child_items) > 0:

# If the project is serial and there is a next action,
# remove the next_action from all children.
if project_type == 'serial' and project_has_next_action:
for child_item in child_items:
remove_label(child_item, label_id)
# Process serial tagged items
if item_type == 'serial':
elif item_type == 'serial':
first_found = False
for child_item in child_items:
first_found = False
if child_item['checked'] == 0 and not first_found:
if is_item_visible(child_item) and not first_found:
add_label(child_item, label_id)
project_has_next_action = True
first_found = True
else:
remove_label(child_item, label_id)
Expand All @@ -163,13 +188,16 @@ def remove_label(item, label):

# Remove the label from the parent
remove_label(item, label_id)
root_first_found = True

# Process items as per project type on indent 1 if untagged
else:
if item['indent'] == 1:
if project_type == 'serial':
if item['item_order'] == 1:
if is_item_visible(item) and not root_first_found:
add_label(item, label_id)
root_first_found = True
project_has_next_action = True
else:
remove_label(item, label_id)
elif project_type == 'parallel':
Expand Down