Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 Hot Fix CORS error in publish GH action workflow #89

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

ebouchut
Copy link
Contributor

@ebouchut ebouchut commented Oct 29, 2024

This PR disables PDF generation temporarily.
The publish GitHub Action workflow fails because of a CORS issue that will be investigated later.
In the meantime, this will allow the website to be published.

ERROR   -  [mkdocs-exporter.pdf.browser] (error) Pump, CGM, Watch - TrioDocs

Access to font at 'https://unpkg.com/[email protected]/es5/output/chtml/fonts/woff-v2/MathJax_Script-Regular.woff' (redirected from 'https://unpkg.com/mathjax@3/es5/output/chtml/fonts/woff-v2/MathJax_Script-Regular.woff')
from origin 'file://' has been blocked by CORS policy: 
No 'Access-Control-Allow-Origin' header is present on the requested resource.

EDIT:
This PR is a workaround.
PR #98 will fix the root cause.

ERROR   -  [mkdocs-exporter.pdf.browser] (error) Pump, CGM, Watch - TrioDocs

Access to font at 'https://unpkg.com/[email protected]/es5/output/chtml/fonts/woff-v2/MathJax_Script-Regular.woff' (redirected from 'https://unpkg.com/mathjax@3/es5/output/chtml/fonts/woff-v2/MathJax_Script-Regular.woff')
from origin 'file://' has been blocked by CORS policy:
No 'Access-Control-Allow-Origin' header is present on the requested resource.
Copy link
Contributor

@MikePlante1 MikePlante1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved by code review

@MikePlante1 MikePlante1 merged commit 7d71a62 into nightscout:dev Oct 29, 2024
@ebouchut ebouchut deleted the fix/ci_disable_pdf_generation branch November 12, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants