Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test new dev version of minimed-connect-to-nightscout #6657

Merged
merged 6 commits into from
Dec 30, 2020
Merged

Conversation

bewest
Copy link
Member

@bewest bewest commented Dec 16, 2020

Try out plugin with recent fixes, thanks to @FredMK. If this tests well we will promote minimed-connect-to-nightscout changes to master and do full release cycle there and update this thread after.

Try out plugin with recent fixes, thanks to @FredMK.
@bewest
Copy link
Member Author

bewest commented Dec 16, 2020

nightscout/minimed-connect-to-nightscout#17

@Sulka, and @FredMK here is a patch to test Nightscout against Frigyes' recent changes.
There may be some ongoing sensitivities with what happens when cloud native plugins need to handle error recovery scenarios.
One scenario is when plugin determines that the failure is permanent: the collected credentials or network access path is not functional and never will be.
Another scenario is when the plugin experiences a transient failure, perhaps related to lockout (eg when Dexcom password changes) or security measures involved with rate limiting (eg we hypothesize Medtronic and Dexcom limits number of concurrent active token) backing off for a while result in a more stable performance.

Been thinking a lot about the kind of observability needed to verify the rate limiting in features like this and am hopeful to have some ideas to help solve this kind of thing across plugins.

@bewest
Copy link
Member Author

bewest commented Dec 16, 2020

@psonnera, @ffernandezro, if this tests ok, I will prep the mmconnect plugin and cgm-remote-monitor for release.

@sulkaharo
Copy link
Member

Right - @bewest I'd love to get the admin messages feature out for release after next, so maybe we should think of extending the plugin API to 1) include a clean method of triggering data loads using the event bus and a defined API for storing new CGM entries and treatments, and 2) method for reporting the integration status, so we'd have a channel to expose issues to users. Would mean additional work for mmconnect but this would clean the system a lot

@AlejandroPaula
Copy link

@Sulka and @bewest I would like to know if this thread would be to be able to connect Ns to the Medtronic MINIMED Mobile and Carelink Connect apps to track 780g in Ns, or if they are working on it, thanks

@danfarcas1972
Copy link

I need help for testing because i cannot find a way to manage with Carelink connection

MiniMed Connect error: Error: Request failed with status code 403

stack: Error: Request failed with status code 403
at createError (/app/node_modules/minimed-connect-to-nightscout/node_modules/axios/lib/core/createError.js:16:15)
at settle (/app/node_modules/minimed-connect-to-nightscout/node_modules/axios/lib/core/settle.js:17:12)
at /app/node_modules/minimed-connect-to-nightscout/node_modules/axios-cookiejar-support/lib/interceptors/response.js:79:25
at new Promise ()
at responseInterceptor (/app/node_modules/minimed-connect-to-nightscout/node_modules/axios-cookiejar-support/lib/interceptors/response.js:78:9)
at /app/node_modules/minimed-connect-to-nightscout/node_modules/axios-cookiejar-support/lib/index.js:130:67
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:97:5)
at async doLoginEu1 (/app/node_modules/minimed-connect-to-nightscout/carelink.js:147:16)
at async checkLogin (/app/node_modules/minimed-connect-to-nightscout/carelink.js:247:32)
Load Complete:
sgvs:547, treatments:1, profiles:1, devicestatus:132, sensorTreatments:1

@mrinnetmaki
Copy link

I need help for testing because i cannot find a way to manage with Carelink connection

MiniMed Connect error: Error: Request failed with status code 403

@tudorfarcas2002 I believe this problem is discussed in at least #6616 (comment) (point 4). nightscout/minimed-connect-to-nightscout#15 might also be relevant.

@bewest
Copy link
Member Author

bewest commented Dec 24, 2020

Thank you for testing, @tudorfarcas2002. Which country are you in? I have found that sometimes setting country code makes a difference, eg MMCONNECT_COUNTRYCODE=us vs MMCONNECT_COUNTRYCODE=gb can make a big difference. Can you share the relevant environment variables used, but without username and password?
Thanks again!

@bewest
Copy link
Member Author

bewest commented Dec 24, 2020

For anyone using this plugin, if it's not working for you currently, please remove mmconnect from the ENABLE list of feature until we can obtain more data

@danfarcas1972
Copy link

danfarcas1972 commented Dec 24, 2020

For anyone using this plugin, if it's not working for you currently, please remove mmconnect from the ENABLE list of feature until we can obtain more data

Hello.
I'm from Romania but in web page i don't select Romania. I leave default selection while the country is from Europe. It work web base, even i select another country from Europe.
Where i can add MMCONNECT_COUNTRYCODE=RO or GB to test again?

@bewest bewest merged commit 76f198a into dev Dec 30, 2020
@benceszasz
Copy link

I have deployed the new dev version in Heroku, but I am still receiving HTTP 403 (EU):

at async doLoginEu1 (/app/node_modules/minimed-connect-to-nightscout/carelink.js:147:16)

MMConnect as a standalon node.js app is working fine for many users, but when I try to run it in Heroku it receives HTTP 403. Are you sure, that Medtronic didn't blacklisted Heroku?

@psonnera
Copy link

Same here. Tried both with an US based and Europe based app. Same issue. Using latest cgm-remote-monitor dev version

@bewest
Copy link
Member Author

bewest commented Dec 31, 2020

Great, thanks for testing! If it's not working in heroku, please ensure mmconnect is absent from the ENABLE list. Getting unblocked will involve the entire community flushing through with zero "bad" attempts from Heroku.

@trucris
Copy link

trucris commented Jan 11, 2021

Nightscout it's working with Carelink. Thanks Ben West , Sulka and all developers

@sulkaharo sulkaharo deleted the wip/bewest/mmconnect branch February 2, 2021 17:54
@ClifClimber
Copy link

Hi all ... I've read this post and I can't undestands if it apply also to Minimed 780G or no yet ??.

Thanks all !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants