forked from woocommerce/woocommerce
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Display price in place order button (woocommerce#47083)
* WIP: Display price in place order button * Add changefile(s) from automation for the following project(s): woocommerce-blocks * Fix JS lint error * Update e2e tests * Display default place order button including placeholder in page editor * Update plugins/woocommerce-blocks/assets/js/blocks/checkout/inner-blocks/checkout-actions-block/constants.tsx Co-authored-by: Seghir Nadir <[email protected]> * Optimise i18n using sprintf * Wrap cart totals in “useSelect” * Temporary skip failing e2e test --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Seghir Nadir <[email protected]>
- Loading branch information
1 parent
c464afc
commit 99bed6d
Showing
6 changed files
with
46 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 6 additions & 2 deletions
8
...mmerce-blocks/assets/js/blocks/checkout/inner-blocks/checkout-actions-block/constants.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,10 @@ | ||
/** | ||
* External dependencies | ||
*/ | ||
import { __ } from '@wordpress/i18n'; | ||
import { __, sprintf } from '@wordpress/i18n'; | ||
|
||
export const defaultPlaceOrderButtonLabel = __( 'Place Order', 'woocommerce' ); | ||
export const defaultPlaceOrderButtonLabel = sprintf( | ||
// translators: %s: is the price. | ||
__( 'Place Order · %s', 'woocommerce' ), | ||
'<price/>' | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
plugins/woocommerce/changelog/47083-update-46010-place-order-button-with-price
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Significance: minor | ||
Type: update | ||
|
||
Display the total price in the place order button. |