pr 问题修改

nieqiurong · May 7, 2022 · 8f9f618 · 8f9f618
1 parent 7f7a7cf
commit 8f9f618
Show file tree

Hide file tree

Showing 5 changed files with 61 additions and 70 deletions.
diff --git a/FirebirdKeyGenerator b/FirebirdKeyGenerator
diff --git a/DmKeyGenerator → ...extension/incrementer/DmKeyGenerator.java b/DmKeyGenerator → ...extension/incrementer/DmKeyGenerator.java
@@ -1,27 +1,23 @@
-package com.baomidou.mybatisplus.extension.incrementer;
-
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-import com.baomidou.mybatisplus.annotation.DbType;
-import com.baomidou.mybatisplus.core.incrementer.IKeyGenerator;
-
-/**
- * DM Sequence
- *
- * @author cdtjj
- * @since 2022-04-22
- */
-
-public class DmKeyGenerator implements IKeyGenerator {
-	@Override
-	public String executeSql(String incrementerName) {
-		// TODO Auto-generated method stub	
-		return "SELECT " + incrementerName + ".NEXTVAL FROM DUAL";
-	}
-
-	@Override
-	public DbType dbType() {
-		// TODO Auto-generated method stub	
-		return DbType.DM;
-	}
-}
+package com.baomidou.mybatisplus.extension.incrementer;
+
+import com.baomidou.mybatisplus.annotation.DbType;
+import com.baomidou.mybatisplus.core.incrementer.IKeyGenerator;
+
+/**
+ * DM Sequence
+ *
+ * @author cdtjj
+ * @since 2022-04-22
+ */
+public class DmKeyGenerator implements IKeyGenerator {
+
+	@Override
+	public String executeSql(String incrementerName) {
+		return "SELECT " + incrementerName + ".NEXTVAL FROM DUAL";
+	}
+
+	@Override
+	public DbType dbType() {
+		return DbType.DM;
+	}
+}
diff --git a/...on/src/main/java/com/baomidou/mybatisplus/extension/incrementer/FirebirdKeyGenerator.java b/...on/src/main/java/com/baomidou/mybatisplus/extension/incrementer/FirebirdKeyGenerator.java
@@ -0,0 +1,17 @@
+package com.baomidou.mybatisplus.extension.incrementer;
+
+import com.baomidou.mybatisplus.annotation.DbType;
+import com.baomidou.mybatisplus.core.incrementer.IKeyGenerator;
+
+public class FirebirdKeyGenerator implements IKeyGenerator {
+
+    @Override
+    public String executeSql(String incrementerName) {
+        return "SELECT next value for " + incrementerName + " from rdb$database";
+    }
+
+    @Override
+    public DbType dbType() {
+        return DbType.FIREBIRD;
+    }
+}
diff --git a/...n/src/main/java/com/baomidou/mybatisplus/extension/plugins/pagination/DialectFactory.java b/...n/src/main/java/com/baomidou/mybatisplus/extension/plugins/pagination/DialectFactory.java
@@ -80,9 +80,9 @@ else if (dbType == DbType.POSTGRE_SQL
                 dialect = new SybaseDialect();
             } else if (dbType == DbType.GBASEDBT) {
                 dialect = new GBasedbtDialect();
-            } else if (dbType == DbType.GBASE_INFORMIX){
+            } else if (dbType == DbType.GBASE_INFORMIX) {
                 dialect = new GBaseInfromixDialect();
-            } else if (dbType == DbType.FIREBIRD){
+            } else if (dbType == DbType.FIREBIRD) {
                 dialect = new FirebirdDialect();
             }
             DIALECT_ENUM_MAP.put(dbType, dialect);

diff --git a/FirebirdDialect → .../pagination/dialects/FirebirdDialect.java b/FirebirdDialect → .../pagination/dialects/FirebirdDialect.java
@@ -1,19 +1,19 @@
-package com.baomidou.mybatisplus.extension.plugins.pagination.dialects;
-
-import com.baomidou.mybatisplus.core.metadata.IPage;
-import com.baomidou.mybatisplus.extension.plugins.pagination.DialectModel;
-import com.baomidou.mybatisplus.extension.plugins.pagination.dialects.IDialect;
-
-/**
- * Firebird 数据库分页语句组装实现,SQL测试版本为4.0
- * 备注：The FIRST/SKIP and ROWS clause are non-standard alternatives
- * @author cdtjj
- * @since 2022-04-26
- */
-public class FirebirdDialect implements IDialect {
-    @Override
-    public DialectModel buildPaginationSql(String originalSql, long offset, long limit) {
-        String sql = originalSql + " OFFSET " + FIRST_MARK + " ROWS FETCH NEXT " + SECOND_MARK + " ROWS ONLY";
-        return new DialectModel(sql, offset, limit).setConsumerChain();
-    }
-}
+package com.baomidou.mybatisplus.extension.plugins.pagination.dialects;
+
+import com.baomidou.mybatisplus.extension.plugins.pagination.DialectModel;
+
+/**
+ * Firebird 数据库分页语句组装实现,SQL测试版本为4.0
+ * 备注：The FIRST/SKIP and ROWS clause are non-standard alternatives
+ *
+ * @author cdtjj
+ * @since 2022-04-26
+ */
+public class FirebirdDialect implements IDialect {
+
+    @Override
+    public DialectModel buildPaginationSql(String originalSql, long offset, long limit) {
+        String sql = originalSql + " OFFSET " + FIRST_MARK + " ROWS FETCH NEXT " + SECOND_MARK + " ROWS ONLY";
+        return new DialectModel(sql, offset, limit).setConsumerChain();
+    }
+}