Use splitmix-0.0.5's nextInteger, and support splitmix-0.1 (i.e. don't rely on RandomGen SMGen instance) #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splitmix-0.1 dropped dependency on random. But that's a non-issue, as QuickCheck doesn't use any `random` instances of `SMGen`, we only need to implement `RandomGen QCGen` in terms of splitmix combinators Related: haskellari/splitmix#34
phadej
changed the title
1 task
This was referenced Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splitmix-0.1 dropped dependency on random. But that's
a non-issue, as QuickCheck doesn't use any
randominstancesof
SMGen, we only need to implementRandomGen QCGenin terms of splitmix combinators
Related: haskellari/splitmix#34
EDIT: I made revisions to
QuickCheck-2.13 .. 2.14to disallowsplitmix-0.1(which doesn't haveRangomGeninstance anymore), e.g. https://hackage.haskell.org/package/QuickCheck-2.14/revisions/EDIT2: Travis job https://travis-ci.org/github/nick8325/quickcheck/builds/692237337