Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blazor number field #2471

Merged
merged 11 commits into from
Nov 14, 2024
Merged

Fix blazor number field #2471

merged 11 commits into from
Nov 14, 2024

Conversation

atmgrifter00
Copy link
Contributor

Pull Request

🤨 Rationale

👩‍💻 Implementation

Most of our input controls bind their current-value attribute in the razor template. The NumberField, however, was binding its value attribute. There doesn't seem to be a valid reason for this, and I have switched it be in-line with the other input controls.

🧪 Testing

Wrote an acceptance test.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@atmgrifter00 atmgrifter00 merged commit 614b921 into main Nov 14, 2024
14 checks passed
@atmgrifter00 atmgrifter00 deleted the fix-Blazor-NumberField branch November 14, 2024 19:15
@atmgrifter00 atmgrifter00 linked an issue Nov 14, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with two-way binding of NimbleNumberField
4 participants