Checkbox error state HLD update #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of the control to future work
|
@m-akinc, will you buddy this PR for me? |
m-akinc
approved these changes
Nov 12, 2024
mollykreis
requested review from
rajsite,
jattasNI and
atmgrifter00
as code owners
atmgrifter00
approved these changes
Nov 12, 2024
jattasNI
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
This is more of a UX / scoping decision than a technical one so I added @fredvisser as a reviewer and I think it's ok not to wait for @rajsite. I'm also ok with verbal signoff from Fred.
I chatted with @fredvisser offline and he said he is ok with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
During development of #2018, I realized that implementing the error state of the checkbox the way it was spec'ed out would be much more difficult than originally thought because making only the label and square checked indicator clickable would break a number of tests (inside & outside of nimble) and would be against ARIA guidelines. Therefore, we decided to keep the effort of the feature more in line with what our original estimates were by deferring the work to update which portion of the control was clickable.
👩💻 Implementation
Update HLD
🧪 Testing
None
✅ Checklist