Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moniker streaming functions return standard reponse message instead of custom data type #1122

Merged
merged 15 commits into from
Nov 26, 2024

Conversation

doshirohan
Copy link
Contributor

@doshirohan doshirohan commented Nov 18, 2024

What does this Pull Request accomplish?

  • Values returned from streaming APIs are now in <function-name>StreamingResponse message.
  • Most of the custom codegen written for Moniker APIs was needed because output was not in standard "response" message. With this change, I was able to delete most of the custom codegen written for streaming functionality.

Why should this Pull Request be merged?

Moniker functions used for streaming data to/from clients used to return custom data types defined in custom_proto.mako file for DAQ and FPGA. This has multiple limitations.

  • The custom types had only one field value for streaming. Read APIs with multiple out parameters need multiple values in response.
  • Response was not provided in standard <function-name>Response message that other grpc APIs use.

What testing has been done?

  • Existing integration tests for FPGA streaming APIs pass.
  • Executed sample client tests with StreamRead/StreamWrite and validated results.

@doshirohan doshirohan force-pushed the users/indoshir/add-request-response-to-stream-api branch from ef77972 to 7278370 Compare November 19, 2024 09:19
@doshirohan doshirohan force-pushed the users/indoshir/add-request-response-to-stream-api branch from 7278370 to baffd64 Compare November 23, 2024 15:21
@doshirohan doshirohan changed the title [do-not-review] Add request/response parameters to moniker APIs Return standard reponse message instead of custom data type for Moniker streaming functions Nov 25, 2024
@doshirohan doshirohan changed the title Return standard reponse message instead of custom data type for Moniker streaming functions Moniker streaming functions return standard reponse message instead of custom data type Nov 25, 2024
@doshirohan doshirohan marked this pull request as ready for review November 25, 2024 12:47
@doshirohan doshirohan merged commit 4f6e50c into main Nov 26, 2024
9 of 10 checks passed
@doshirohan doshirohan deleted the users/indoshir/add-request-response-to-stream-api branch November 26, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants