-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moniker streaming functions return standard reponse message instead of custom data type #1122
Merged
doshirohan
merged 15 commits into
main
from
users/indoshir/add-request-response-to-stream-api
Nov 26, 2024
Merged
Moniker streaming functions return standard reponse message instead of custom data type #1122
doshirohan
merged 15 commits into
main
from
users/indoshir/add-request-response-to-stream-api
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doshirohan
force-pushed
the
users/indoshir/add-request-response-to-stream-api
branch
from
November 19, 2024 09:19
ef77972
to
7278370
Compare
…ponse on moniker out param
doshirohan
force-pushed
the
users/indoshir/add-request-response-to-stream-api
branch
from
November 23, 2024 15:21
7278370
to
baffd64
Compare
doshirohan
changed the title
[do-not-review] Add request/response parameters to moniker APIs
Return standard reponse message instead of custom data type for Moniker streaming functions
Nov 25, 2024
doshirohan
changed the title
Return standard reponse message instead of custom data type for Moniker streaming functions
Moniker streaming functions return standard reponse message instead of custom data type
Nov 25, 2024
doshirohan
requested review from
reckenro,
astarche and
maxxboehme
as code owners
November 25, 2024 12:47
Raghav-NI
approved these changes
Nov 25, 2024
reckenro
reviewed
Nov 25, 2024
reckenro
approved these changes
Nov 25, 2024
doshirohan
deleted the
users/indoshir/add-request-response-to-stream-api
branch
November 26, 2024 11:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
<function-name>StreamingResponse
message.Why should this Pull Request be merged?
Moniker functions used for streaming data to/from clients used to return custom data types defined in
custom_proto.mako
file for DAQ and FPGA. This has multiple limitations.value
for streaming. Read APIs with multiple out parameters need multiple values in response.<function-name>Response
message that other grpc APIs use.What testing has been done?