Improve install guide navigation #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current the Install guide index page uses a form with radios to route people to one of three pages. This replaces the form with links, as those are generally better for navigation (for example can be opened in a new tab). It also combines the "Download the kit" page with the advanced install guide to simplify things.
frankieroberto
temporarily deployed
to
nhs-prototyp-improve-in-le4xgk
Co-authored-by: Ed Horsford <[email protected]>
frankieroberto
temporarily deployed
to
nhs-prototyp-improve-in-le4xgk
frankieroberto
commented
Oct 29, 2024
frankieroberto
temporarily deployed
to
nhs-prototyp-improve-in-le4xgk
…K content conventions
vickytnz
previously requested changes
Nov 1, 2024
|
Not a blocking change, but I wonder if the difference between the two guides are: Choose from the:
|
frankieroberto
dismissed
vickytnz’s stale review
Changes made by Vicky and the rest are non-blocking
I like this idea. Wasn't sure if step-by-step should be hyphenated or not though - GOVUK doesn't seem to. They also front-load the main words, so it'd be "Install guide: step by step"? See pattern. Have merged for now. We can continue tweaking content as follow-up PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current the Install guide index page uses a form with radios to route people to one of three pages.
This replaces the form with links, as those are generally better for navigation (for example can be opened in a new tab).
The "developer-friendly" install guide is renamed as "advanced", as it might not just be for developers.
It also combines the "Download the kit" page with the advanced install guide to simplify it a bit.
Screenshots