-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seeking clarification on parent/TOPMed study differences #2
base: master
Are you sure you want to change the base?
Conversation
merge to update my own fork
Clarifications based on my understanding.
Hi Ash, good questions.
Therefore the answer is a bit tricky, but for the most part 1) if you want to run a GWAS or just want pheno + geno then go with parent. If you want geno go with TOPMed, and ultimately you can do both if you want to double check or do the subject linking yourself in the workspace |
Let's just pretend I didn't misclick and close the PR for a second there... @ac3eb Should we notify users of the discrepancy, or do you think that the mismatch (ie lack of 300 CRAMs in the case of COPDGene) is not important in the grand scheme of things? |
Hmm, I don't think we should call it a discrepancy or lack of CRAMs since the link is correct. It's simply a nature of the studies, wherein not all of the subjects are present in parent and TOPMed. The situation would be the same if they tried to establish that link separately by accessing parent and then TOPMed. I do think it's a great idea to mention that they shouldn't expect both pools of subjects to match 100% every time. In fact, we've seen a couple of examples where there is a 0% match between parent and TOPMed, even though TOPMed studies are technically considered child studies of the parent. I can add an explanation to that section on what Gen3 does to create that link and how it works when exporting a study. Note that we created that link between parent and TOPMed subjects after receiving several requests. |
I do think that explanation would be helpful, especially since that link was so widely requested. For instance, I still don't quite understand why a parent and TOPMed study would have 0% overlap. That being said -- if our researchers are coming from a TOPMed background, this may be a lot less mysterious to them than it is to me. So whatever you think is appropriate in terms of explanation, I'll go along with that. R/e adding an explanation, should I merge this PR so you can add your contributions easily? |
The older version was a bit unclear as to what the user should actually expect when in Gen3 when looking at a Parent study, especially as the line about Parent studies lacking genomic data came after saying that in Gen3 they do have genomic data if there is also a TOPMed study.
I still have some questions that need to be reflected in the documentation though, so please let me know so I can add good information to this PR before it's pulled: