Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate RegisterContext #17

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Deprecate RegisterContext #17

merged 1 commit into from
Jan 22, 2024

Conversation

nhatthm
Copy link
Owner

@nhatthm nhatthm commented Jan 22, 2024

Description

Deprecate RegisterContext

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0a5f620) 100.00% compared to head (8a7b1f1) 98.75%.

Files Patch % Lines
manager.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master      #17      +/-   ##
===========================================
- Coverage   100.00%   98.75%   -1.25%     
===========================================
  Files            3        3              
  Lines          159      161       +2     
===========================================
  Hits           159      159              
- Misses           0        2       +2     
Flag Coverage Δ
featurestests-Linux 90.68% <71.42%> (-1.15%) ⬇️
featurestests-macOS 90.68% <71.42%> (-1.15%) ⬇️
unittests-Linux 70.18% <0.00%> (-0.89%) ⬇️
unittests-macOS 70.18% <0.00%> (-0.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nhatthm nhatthm merged commit 188e80c into master Jan 22, 2024
12 of 14 checks passed
@nhatthm nhatthm deleted the rename-register branch January 22, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant