Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: add logic to moksha-wallet dependencies #247

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

EthnTuttle
Copy link

While attempting to compile for esp32 boards using esp-rs crates, moksha-wallet couldn't be depended on because of various compile errors. When compiling for esp, you are not targeting wasm. Irconically, the wasm dependencies mostly compiled for esp. This commit adds logic so espcash can depend directly on moksha to more easily implement an ecash clinet for embedded devices.

@ngutech21
Copy link
Owner

LGTM

We need an additional github Action for compiling to esp and a just task like build-esp that gets called in final-check

@EthnTuttle
Copy link
Author

LGTM

We need an additional github Action for compiling to esp and a just task like build-esp that gets called in final-check

I'm going to hold off on that.

  1. I can run cargo build in the espcash repo but have yet to actually implement any logic.
  2. Compiling for esp takes a lot of extra "stuff" that I'm not ready to integrate into a GH action.

I plan to keep this branch open on my fork for development and once I get some more progress on a PoC for the embedded implementation, I'll make a task to work toward compiling and such directly within the moksha repo.

My PoC goal is a naive impl of moksha-cli but for the embedded device.

Thank you for helping sort out the dependency issues.

(ps. happy to close this PR while I work, as I anticipate this sitting open for a while)

While attempting to compile for esp32 boards using esp-rs crates, moksha-wallet couldn't
be depended on because of various compile errors. When compiling for esp, you are not targeting
wasm. Irconically, the wasm dependencies mostly compiled for esp. This commit adds logic so
espcash can depend directly on moksha to more easily implement an ecash clinet for embedded devices.
@EthnTuttle EthnTuttle force-pushed the espcash-espidf-cargo-toml branch from 8e3d10c to 9aed9d8 Compare March 5, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants