Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump lightning from 0.0.116 to 0.0.118 #162

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 24, 2023

Bumps lightning from 0.0.116 to 0.0.118.

Release notes

Sourced from lightning's releases.

v0.0.118

0.0.118 - Oct 23, 2023 - "Just the Twelve Sinks"

API Updates

  • BOLT12 sending and receiving is now supported as an alpha feature. You may run into unexpected issues and will need to have a direct connection with the offer's blinded path introduction points as messages are not yet routed. We are seeking feedback from early testers (#2578, #2039).
  • ConfirmationTarget has been rewritten to provide information about the specific use LDK needs the feerate estimate for, rather than the generic low-, medium-, and high-priority estimates. This allows LDK users to more accurately target their feerate estimates (#2660). For those wishing to retain their existing behavior, see the table below for conversion.
  • ChainHash is now used in place of BlockHash where it represents the genesis block (#2662).
  • lightning-invoice payment utilities now take a Deref to AChannelManager (#2652).
  • peel_onion is provided to statelessly decode an OnionMessage (#2599).
  • ToSocketAddrs + Display are now impl'd for SocketAddress (#2636, #2670)
  • Display is now implemented for OutPoint (#2649).
  • Features::from_be_bytes is now provided (#2640).

For those moving to the new ConfirmationTarget, the new variants in terms of the old mempool/low/medium/high priorities are as follows:

  • OnChainSweep = HighPriority
  • MaxAllowedNonAnchorChannelRemoteFee = max(25 * 250, HighPriority * 10)
  • MinAllowedAnchorChannelRemoteFee = MempoolMinimum
  • MinAllowedNonAnchorChannelRemoteFee = Background - 250
  • AnchorChannelFee = Background
  • NonAnchorChannelFee = Normal
  • ChannelCloseMinimum = Background

Bug Fixes

  • Calling ChannelManager::close_channel[_with_feerate_and_script] on a channel which did not exist would immediately hang holding several key ChannelManager-internal locks (#2657).
  • Channel information updates received from a failing HTLC are no longer applied to our NetworkGraph. This prevents a node which we attempted to route a payment through from being able to learn the sender of the payment. In some rare cases, this may result in marginally reduced payment success rates (#2666).
  • Anchor outputs are now properly considered when calculating the amount available to send in HTLCs. This can prevent force-closes in anchor channels when sending payments which overflow the available balance (#2674).
  • A peer that sends an update_fulfill_htlc message for a forwarded HTLC, then reconnects prior to sending a commitment_signed (thus retransmitting their update_fulfill_htlc) may result in the channel stalling and being unable to make progress (#2661).
  • In exceedingly rare circumstances, messages intended to be sent to a peer prior to reconnection can be sent after reconnection. This could result in

... (truncated)

Changelog

Sourced from lightning's changelog.

0.0.118 - Oct 23, 2023 - "Just the Twelve Sinks"

API Updates

  • BOLT12 sending and receiving is now supported as an alpha feature. You may run into unexpected issues and will need to have a direct connection with the offer's blinded path introduction points as messages are not yet routed. We are seeking feedback from early testers (#2578, #2039).
  • ConfirmationTarget has been rewritten to provide information about the specific use LDK needs the feerate estimate for, rather than the generic low-, medium-, and high-priority estimates. This allows LDK users to more accurately target their feerate estimates (#2660). For those wishing to retain their existing behavior, see the table below for conversion.
  • ChainHash is now used in place of BlockHash where it represents the genesis block (#2662).
  • lightning-invoice payment utilities now take a Deref to AChannelManager (#2652).
  • peel_onion is provided to statelessly decode an OnionMessage (#2599).
  • ToSocketAddrs + Display are now impl'd for SocketAddress (#2636, #2670)
  • Display is now implemented for OutPoint (#2649).
  • Features::from_be_bytes is now provided (#2640).

For those moving to the new ConfirmationTarget, the new variants in terms of the old mempool/low/medium/high priorities are as follows:

  • OnChainSweep = HighPriority
  • MaxAllowedNonAnchorChannelRemoteFee = max(25 * 250, HighPriority * 10)
  • MinAllowedAnchorChannelRemoteFee = MempoolMinimum
  • MinAllowedNonAnchorChannelRemoteFee = Background - 250
  • AnchorChannelFee = Background
  • NonAnchorChannelFee = Normal
  • ChannelCloseMinimum = Background

Bug Fixes

  • Calling ChannelManager::close_channel[_with_feerate_and_script] on a channel which did not exist would immediately hang holding several key ChannelManager-internal locks (#2657).
  • Channel information updates received from a failing HTLC are no longer applied to our NetworkGraph. This prevents a node which we attempted to route a payment through from being able to learn the sender of the payment. In some rare cases, this may result in marginally reduced payment success rates (#2666).
  • Anchor outputs are now properly considered when calculating the amount available to send in HTLCs. This can prevent force-closes in anchor channels when sending payments which overflow the available balance (#2674).
  • A peer that sends an update_fulfill_htlc message for a forwarded HTLC, then reconnects prior to sending a commitment_signed (thus retransmitting their update_fulfill_htlc) may result in the channel stalling and being unable to make progress (#2661).
  • In exceedingly rare circumstances, messages intended to be sent to a peer prior to reconnection can be sent after reconnection. This could result in undefined channel state and force-closes (#2663).

... (truncated)

Commits
  • d2242f6 Merge pull request #2678 from TheBlueMatt/2023-10-0.0.118
  • b664875 Bump crate versions to lightning 0.0.118, invoice 0.26
  • 2587f70 0.0.118 release notes
  • d0795d8 Merge pull request #2679 from TheBlueMatt/2023-10-116-bindings-1
  • 35eb38d Fix CI on rustc 1.50 and below
  • 49a5fdf Use a tuple, not a struct, for PendingOnionMessage in bindings
  • 3f416bc Merge pull request #2676 from TheBlueMatt/2023-10-various-followups
  • 32d2d0f Add relevant no-export tags to functions returning builders
  • 4918c41 Drop an unnecessary no-export on ParsedOnionMessageContents
  • 4443db6 Do not compile the Simple* type aliases in c_bindings at all
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Oct 24, 2023
@dependabot dependabot bot force-pushed the dependabot/cargo/lightning-0.0.118 branch 2 times, most recently from 7485215 to 7155277 Compare October 31, 2023 15:14
@dependabot dependabot bot force-pushed the dependabot/cargo/lightning-0.0.118 branch 2 times, most recently from 9f19164 to 788df01 Compare November 10, 2023 14:30
@dependabot dependabot bot force-pushed the dependabot/cargo/lightning-0.0.118 branch from 788df01 to b4b0d73 Compare November 21, 2023 08:43
Bumps [lightning](https://github.com/lightningdevkit/rust-lightning) from 0.0.116 to 0.0.118.
- [Release notes](https://github.com/lightningdevkit/rust-lightning/releases)
- [Changelog](https://github.com/lightningdevkit/rust-lightning/blob/main/CHANGELOG.md)
- [Commits](lightningdevkit/rust-lightning@v0.0.116...v0.0.118)

---
updated-dependencies:
- dependency-name: lightning
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/lightning-0.0.118 branch from b4b0d73 to 5c66372 Compare November 22, 2023 06:38
Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 18, 2024

Superseded by #203.

@dependabot dependabot bot closed this Jan 18, 2024
@dependabot dependabot bot deleted the dependabot/cargo/lightning-0.0.118 branch January 18, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants