refactor: replace class with variable

ngneat · Apr 28, 2024 · 66c68ab · 66c68ab
1 parent c3a710f
commit 66c68ab
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/apps/playground/src/app/app.component.ts b/apps/playground/src/app/app.component.ts
@@ -77,8 +77,8 @@ export class AppComponent {
     this.backDropClicked = false;
     this.cleanConfig = this.normalizeConfig(config);
 
-    if (this.cleanConfig.overflow) document.body.classList.add('overflow');
-    else document.body.classList.remove('overflow');
+    if (this.cleanConfig.overflow) document.body.style.setProperty('--dialog-overflow', 'visible');
+    else document.body.style.setProperty('--dialog-overflow', 'hidden');
 
     const ref = this.dialog.open(compOrTemplate as any, this.cleanConfig);
 

diff --git a/libs/dialog/src/lib/dialog.component.scss b/libs/dialog/src/lib/dialog.component.scss
@@ -99,6 +99,6 @@
   }
 }
 
-body.ngneat-dialog-hidden:not(.overflow) {
-  overflow: hidden;
+body {
+  overflow: var(--dialog-overflow, hidden);
 }
diff --git a/libs/dialog/src/lib/dialog.component.ts b/libs/dialog/src/lib/dialog.component.ts
@@ -115,6 +115,10 @@ export class DialogComponent implements OnInit, OnDestroy {
       }
     }
 
+    if (this.config.overflow) {
+      document.body.style.setProperty('--dialog-overflow', 'visible');
+    }
+
     this.host.id = this.config.id;
   }
-Original file line number
+Diff line change
@@ Expand Up @@
           }
         }
+        if (this.config.overflow) {
+          document.body.style.setProperty('--dialog-overflow', 'visible');
+        }
         this.host.id = this.config.id;
       }
@@ Expand Down @@