-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: module of utilities for integration tests #74
base: master
Are you sure you want to change the base?
Conversation
Hi there, once again thank you for all of your contributions. I talked over this PR with some of the other project maintainers and there is a strong opinion that this functionality may be better in another project/library that supplements |
Of course possible (and I agree to split it from the core), but before changing let me clarify which is better, creating a new GitHub repository, or just separating it into a new subdirectory in this repository, just like |
There's It's also optional and could be omitted by the buildsystem if you specify an empty --prefix (we do that for the official Windows builds), but that's only a problem with non-vendored Nginx source tree. |
Thank you for important information. Now |
Splitting the module to another project could cause incompatible (different version) two indirect dependencies to |
Proposed changes
This PR adds
test_util
module, utilities for integration tests of Nginx modules. The utilities were moved fromtests/log_test.rs
, and fixed to use the bundled Nginx used in bindings, the install path of which is recorded innginx-sys::metadata::NGINX_INSTALL_DIR
.Checklist
Before creating a PR, run through this checklist and mark each as complete.