-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lookup plugin to use native api #136
Conversation
@resmo have you see that? |
Thanks for pinging me. I added myself as reviewer. In general, I agree with this functionality. However, I'm in the middle of a major refactoring (see #141) that will be done by about the end of the year. Would it be ok to take a look at this PR when the dust has settled a bit? |
Hi @resmo , no problem, in the meantime i will use my fork with this enhancement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your suggestion. I'd like to have this lookup plugin merged for 3.0.0. However, I wonder why you created another module_utils for it. Can you explain?
@tanganellilore please rebase |
Hi, to due different init and api function, moreover, to separate lookup/api module to other module. Api lookup is very flexible without any specific check. |
sorry again, could you please rebase again |
LGTM, I may re-arrange code a bit but it's good for now. |
Hi team,
In this PR I added the functionality to use native API via lookup plugin.
I'm simply inspired from AWX controller_api so the implementation it's very simple and without special checks.
Lookup working like controller_apu lookup, ex:
This is very usefull for usecase like listing elements or simply query the api, without any logic that generally is present on a module (like automatic retrival of id from a name).
Let me know it this can be a good starting point.
Thanks