Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cs_instance user_data_details and _name #134

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

tanganellilore
Copy link
Contributor

Hi team,

I added the user_data_detail field on cs_instance.py and fix a bug on validate_certs.

@resmo
Copy link
Member

resmo commented Sep 18, 2024

@tanganellilore could you please make 2 PRs of this: one for the fix, one for the feature. Thanks!

@tanganellilore
Copy link
Contributor Author

@resmo News on it?

@resmo
Copy link
Member

resmo commented Sep 25, 2024

Thanks for this, I'll merge it like this and create some minor adjustments.

@resmo resmo merged commit 271b448 into ngine-io:master Sep 25, 2024
0 of 4 checks passed
@resmo resmo changed the title Add cs_instance user_data_detailand fix validates_certs Add cs_instance user_data_details and _name Sep 25, 2024
resmo added a commit that referenced this pull request Sep 25, 2024
@tanganellilore tanganellilore deleted the add_missing_api_params branch October 28, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants