-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: Remove IFDs #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The kikit stuff LGTU (@ngi-nix/fungus)! Thanks for dealing with it. We actually had to remove IFD when we submitted this stuff to try to upstream it to nixpkgs in NixOS/nixpkgs#249464, sorry for the duplicated work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good to me! The only thing I see missing is to replace the use of liberaforms as an example in the README for adding and deploying a service: https://github.com/ngi-nix/ngipkgs/blob/main/README.md?plain=1#L43-L49
I think pretalx would be an excellent alternative to liberaforms in this section. It doesn't need to be exactly the same things covered, you can just copy what you've already put in your README for pretalx, so it could be changed to "Add and test a service" and we can include more about deployment later.
I'm working now on making this edit to the README using the pretalx example, hopefully a commit coming soon.
Nooice |
Relates to:
nix flake check
withno-url-literals
fails #39