Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repackage liberaforms without mach-nix #40

Closed
cleeyv opened this issue Aug 23, 2023 · 2 comments
Closed

Repackage liberaforms without mach-nix #40

cleeyv opened this issue Aug 23, 2023 · 2 comments
Assignees
Labels
bug Something isn't working package Create a Nix package

Comments

@cleeyv
Copy link
Collaborator

cleeyv commented Aug 23, 2023

Issue #39 identifies how the use of mach-nix for liberaforms (which uses an IDF) depended on an old version of nixpkgs as a workaround to a bug a with mach-nix DavHau/mach-nix#549 which made it incompatible with newer versions of nixpkgs. That is documented here: https://github.com/ngi-nix/ngipkgs/blob/main/pkgs/liberaforms/env.nix#L9-L16 it was from back in June when we set up ngipkgs with liberaforms as the initial test service.

Since then, I see that in early July a new PR was merged for mach-nix DavHau/mach-nix#563 that apparently fixes the incompatibility with newer nixpkgs. Assuming this fix works, then in theory this issue could be resolved by sourcing the import of mach-nix for liberaforms from its master branch (to include the fix) and then removing the old nixpkgs workaround. I tried this here: https://github.com/ngi-nix/ngipkgs/tree/remove-old-nixpkgs but ran into the following error (which was also problematic in earlier iterations of packaging liberaforms):

Some requirements could not be resolved.
Top level requirements: 
  alembic==1.7.5  attrs==21.4.0  Babel==2.9.1  beautifulsoup4==4.10.0  bleach==4.1.0  cachelib==0.5.0  certifi==2021.10.8  cffi==1.15.0  charset-normalizer==2.0.9  click==8.0.3  cryptography==36.0.0  dnspython==2.1.0  email-validator==1.1.3  feedgen==0.9.0  F>
Providers:
  {'_default': ['wheel', 'sdist', 'nixpkgs'],
   'gdal': ['nixpkgs'],
   'pip': ['nixpkgs', 'sdist'],
   'setupmeta': ['wheel'],
   'setuptools': ['nixpkgs'],
   'wheel': ['nixpkgs', 'sdist']}
Mach-nix version: master
Python: 3.10.12
Cause: Requirements conflict: cryptography (<SpecifierSet('==36.0.0')>,)
The requirements which caused the error:
  cryptography (<SpecifierSet('==36.0.0')>,)

The given requirements might contain package versions which are not yet part of the dependency DB
currently used. The DB can be updated by specifying 'pypiDataRev' when importing mach-nix.
For examples see: https://github.com/DavHau/mach-nix/blob/master/examples.md

As discussed in #24, the use of an IFD by mach-nix for the liberaforms package is already a problem for CI performance, and there are likely going to continue to be problems with mach-nix since it doesn't seem to be very actively maintained anymore. Therefore this new issue with mach-nix raised in issue #39 is adding to a growing list of reasons to disable liberaforms in ngipkgs until further work can be done on it to transition away from the use of mach-nix and IFDs, perhaps also as part of updating the packaging to a new version 3.0 of liberaforms which looks like it could come out sometime in the next year.

Tracking issue: #12

@cleeyv cleeyv added bug Something isn't working package Create a Nix package labels Aug 23, 2023
@github-project-automation github-project-automation bot moved this to under mobsideration in Summer of Nix Aug 23, 2023
lorenzleutgeb added a commit that referenced this issue Aug 24, 2023
Relates to:
 - #24
 - #39
 - #40
@alejandrosame alejandrosame self-assigned this Nov 15, 2023
@augustebaum augustebaum removed their assignment Nov 18, 2023
@alejandrosame alejandrosame removed their assignment Dec 30, 2023
@wamirez wamirez moved this to Todo in Migration Apr 17, 2024
@wamirez wamirez moved this from Todo to In Progress in Migration Apr 17, 2024
@fricklerhandwerk
Copy link
Collaborator

Closed by #194

@github-project-automation github-project-automation bot moved this from In Progress to Done in Migration Apr 25, 2024
@github-project-automation github-project-automation bot moved this from under mobsideration to mobleted in Summer of Nix Apr 25, 2024
@lorenzleutgeb
Copy link
Member

lorenzleutgeb commented May 3, 2024

Archiving https://github.com/ngi-nix/liberaforms-flake/ now. Missing permissions. @fricklerhandwerk please archive that repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package Create a Nix package
Projects
Status: Done
Status: mobleted
Development

No branches or pull requests

6 participants