It become unstable behavior when implement UITableViewDelegate method that return estimatedHeight #50
+8
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeeeen
changed the title
ra1028
requested changes
Sep 13, 2018
Hakuba/Source/Core/Hakuba.swift
Outdated
| } | ||
| // public func tableView(_ tableView: UITableView, estimatedHeightForRowAt indexPath: IndexPath) -> CGFloat { | ||
| // return self.tableView(tableView, heightForRowAt: indexPath) | ||
| // } |
There was a problem hiding this comment.
Please remove the commented out codes.
Could you describe the usage of UITableViewAutomaticDimension in README?
added 2 commits
October 3, 2018 16:10
|
@ra1028 Thank you for the review and I fixed you pointed out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comment out
tableView(_ tableView:, estimatedHeightForRowAt:) -> CGFloat