Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KML default altitude mode and line tessellate support #1412

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

schmidtk
Copy link
Contributor

@schmidtk schmidtk commented Dec 3, 2021

This fixes a couple issues identified in #907. Namely:

  • I don't think we are properly defaulting altitudeMode to clampToGround
  • I don't think we are properly reading tessellate, which should correspond to os.interpolate.Method.NONE if 0

The first is true of all geometries. The KML specification states altitude mode should default to clampToGround for all geometry types. The KML parser will now do this if altitudeMode is not set on the parsed geometry.

For the second item, if tessellate is disabled (0 or false) we will disable interpolation on the geometry. I also updated the Cesium converter to use Cesium.ArcType.NONE when interpolation is disabled. This will render geometries as defined by the KML spec.

@schmidtk schmidtk self-assigned this Dec 3, 2021
@schmidtk schmidtk merged commit 9bf8211 into ngageoint:master Dec 6, 2021
@schmidtk schmidtk deleted the feat-kml-linestring branch December 6, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants