This repository has been archived by the owner on Jun 14, 2018. It is now read-only.
Fixed issue where failed vet tasks wouldn't emit error breaking build #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The addition of the gulp task 'live-dev' introduced a regression in our build process. The task 'live-dev' has to swallow all errors so the process does not terminate, rather it keeps running to watch for file changes for continuous development. However when vetting code, this means the `emitError` on the TSLINT utility must be set to false telling it to not emit any errors. While this works for `live-dev`, the vetting gulp tasks now write out the linting errors found, but the process does not exit as an error. The effects of this is our CD process does not detect these errors are build errors which it should. This fix adds an optional `--noExit` argument to the vetting tasks. If set, the TSLINT utility will write the error, but not emit an error making it work for the live-dev. The default state though is to fail the process, resolving the issue with our CD process. Closes ngOfficeUIFabric#192.
Gulp task `test` was missing the `--file` optional argument that could be passed in in the list of available options.
andrewconnell
force-pushed
the
build-refactor
branch
from
a98fa15 to
42caa05
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue when a failed vet would not emit an error and thus, break the build. New optional parameter
--noExittells the vet tasks to not emit an error. By default they do emit errors again, but when running thelive-devtask, it swallows the error code and just writes the error message.Look at full commit message on 79e08db for full details.
Closes #192.