This repository has been archived by the owner on Jun 14, 2018. It is now read-only.
Build doesn't fail in Travis if any vet errors #192
Comments
|
I can take this on in my build updates i'm working on as this is tightly related to #170... cool? if you agree, feel free to reassign to me |
|
Cool! :) |
andrewconnell
added a commit
to andrewconnell/ng-officeuifabric
that referenced
this issue
Mar 5, 2016
The addition of the gulp task 'live-dev' introduced a regression in our build process. The task 'live-dev' has to swallow all errors so the process does not terminate, rather it keeps running to watch for file changes for continuous development. However when vetting code, this means the `emitError` on the TSLINT utility must be set to false telling it to not emit any errors. While this works for `live-dev`, the vetting gulp tasks now write out the linting errors found, but the process does not exit as an error. The effects of this is our CD process does not detect these errors are build errors which it should. This fix adds an optional `--noExit` argument to the vetting tasks. If set, the TSLINT utility will write the error, but not emit an error making it work for the live-dev. The default state though is to fail the process, resolving the issue with our CD process. Closes ngOfficeUIFabric#192.
andrewconnell
added a commit
to andrewconnell/ng-officeuifabric
that referenced
this issue
Mar 5, 2016
The addition of the gulp task 'live-dev' introduced a regression in our build process. The task 'live-dev' has to swallow all errors so the process does not terminate, rather it keeps running to watch for file changes for continuous development. However when vetting code, this means the `emitError` on the TSLINT utility must be set to false telling it to not emit any errors. While this works for `live-dev`, the vetting gulp tasks now write out the linting errors found, but the process does not exit as an error. The effects of this is our CD process does not detect these errors are build errors which it should. This fix adds an optional `--noExit` argument to the vetting tasks. If set, the TSLINT utility will write the error, but not emit an error making it work for the live-dev. The default state though is to fail the process, resolving the issue with our CD process. Closes ngOfficeUIFabric#192.
andrewconnell
added a commit
to andrewconnell/ng-officeuifabric
that referenced
this issue
Mar 5, 2016
The addition of the gulp task 'live-dev' introduced a regression in our build process. The task 'live-dev' has to swallow all errors so the process does not terminate, rather it keeps running to watch for file changes for continuous development. However when vetting code, this means the `emitError` on the TSLINT utility must be set to false telling it to not emit any errors. While this works for `live-dev`, the vetting gulp tasks now write out the linting errors found, but the process does not exit as an error. The effects of this is our CD process does not detect these errors are build errors which it should. This fix adds an optional `--noExit` argument to the vetting tasks. If set, the TSLINT utility will write the error, but not emit an error making it work for the live-dev. The default state though is to fail the process, resolving the issue with our CD process. Closes ngOfficeUIFabric#192.
andrewconnell
added
waffleio:pending-integration
waffleio:merged-into-dev
and removed
needs-review
waffleio:pending-integration
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
For
tslinttask settingemitError: falsewas added to prevent breaking pipeline forlive-devtask.In this case Travis build doesn't fail and shows green state.
Proposed solution:
Leave it as is for "regular" tasks, but add additional param for travis, so in travis config it will be something like this
gulp vet-lib-ts --verbose --emitErrorThe text was updated successfully, but these errors were encountered: