fix: fix circles convertion when no cx/cy

fix #162
nfroidure · Sep 8, 2024 · 13d9caf · 13d9caf
1 parent cd86ee5
commit 13d9caf
Show file tree

Hide file tree

Showing 6 changed files with 28 additions and 47 deletions.
diff --git a/fixtures/expected/realworld.svg b/fixtures/expected/realworld.svg
diff --git a/fixtures/icons/realworld/omridevk.svg b/fixtures/icons/realworld/omridevk.svg
diff --git a/src/svgshapes2svgpath.ts b/src/svgshapes2svgpath.ts
@@ -90,8 +90,8 @@ function svgShapesToPathLineToPath(attributes) {
 }
 
 function svgShapesToPathCircleToPath(attributes) {
-  const cx = parseFloat(attributes.cx);
-  const cy = parseFloat(attributes.cy);
+  const cx = parseFloat(attributes.cx || 0);
+  const cy = parseFloat(attributes.cy || 0);
   const rx =
     'undefined' !== typeof attributes.rx
       ? parseFloat(attributes.rx)

diff --git a/src/tests/index.test.ts b/src/tests/index.test.ts
@@ -281,6 +281,12 @@ describe('Generating fonts to files', () => {
     });
   });
 
+  test('should work with realworld icons', async () => {
+    await generateFontToFile({
+      fontName: 'realworld',
+    });
+  });
+
   test('should work with a lot of icons', async () => {
     await generateFontToFile(
       {

diff --git a/src/tests/results/nestedicons-cli.svg b/src/tests/results/nestedicons-cli.svg
diff --git a/src/tests/results/originalicons-cli.svg b/src/tests/results/originalicons-cli.svg