-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly sanitize object replacement character by treating as whitespace #495
Labels
Comments
5 tasks
Hi Alex, thanks for reporting! This should be a doable fix, linkify can interpret |
Thank you @nfrasser 🙇🏻 |
1 task
nfrasser
added a commit
that referenced
this issue
Dec 4, 2024
nfrasser
added a commit
that referenced
this issue
Dec 4, 2024
nfrasser
changed the title
Object Replacement Characters not being sanitized
Correctly sanitize object replacement character by treating as whitespace
Dec 4, 2024
@alexvcasillas fix is available in the latest v4.2.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey there, I'm Alex from Tiptap 👋🏻
I wanted to upstream this issue to you as it's something that's affecting
linkifyjs
directly. It seems thatlinkifyjs
does not handle properly the sanitization of a string when it comes to thefind
method that looks for link matches within a string. Here's an example of this character:\uFFFC
this is an object replacement character and it looks like an empty string to the naked eye but if you pass something likefind('https://google.com this)
(where the space between the .com and this is the given character\uFFFC
) the method will return you that the link ishttps://google.com this
which some might say it's correct as it's a valid unicode character but people will be very confused by this as we've been by the reports we were having in our editor repo.Just wanted to upstream this to you to see if it's something that you'd consider adding to the
find
method or to help anyone that might be having this issue so they know what could be about.This was the issue in which we ended up discovering this ueberdosis/tiptap#5679 just in case you're curious what this could potentially cause :)
Hope you have a great day 🙇🏻
The text was updated successfully, but these errors were encountered: