Code review

Copy the file only if we cannot move it.
nfl · Jan 28, 2020 · 2ad856a · 2ad856a
1 parent 49e6a77
commit 2ad856a
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/ios/ImagePickerManager.m b/ios/ImagePickerManager.m
@@ -466,8 +466,14 @@ - (void)imagePickerController:(UIImagePickerController *)picker didFinishPicking
 
                 if (videoURL) { // Protect against reported crash
                   NSError *error = nil;
-                  // iOS 13 b2 may not allow write access to tmp on a trimmed video clip
-                  [fileManager copyItemAtURL:videoURL toURL:videoDestinationURL error:&error];
+
+                  // If we have write access to the source file, move it. Otherwise use copy. 
+                  if ([fileManager isWritableFileAtPath:[videoURL path]]) {
+                    [fileManager moveItemAtURL:videoURL toURL:videoDestinationURL error:&error];
+                  } else {
+                    [fileManager copyItemAtURL:videoURL toURL:videoDestinationURL error:&error];
+                  }
+
                   if (error) {
                       self.callback(@[@{@"error": error.localizedFailureReason}]);
                       return;