This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
V1.0.1 (react-native-image-picker#1120)
refactor: Replace JavaScript with TypeScript and AndroidX support
- Loading branch information
1 parent
8de2847
commit 11dcf31
Showing
46 changed files
with
1,340 additions
and
2,630 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
typings | ||
node_modules | ||
example/android-bundle.js | ||
example/ios-bundle.js | ||
|
||
# generated by bob | ||
lib |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
* @format | ||
*/ | ||
|
||
const typescriptEslintRecommended = require('@typescript-eslint/eslint-plugin/dist/configs/recommended.json'); | ||
const typescriptEslintPrettier = require('eslint-config-prettier/@typescript-eslint'); | ||
|
||
module.exports = { | ||
extends: ['@react-native-community'], | ||
overrides: [ | ||
{ | ||
files: ['*.ts', '*.tsx'], | ||
// Apply the recommended Typescript defaults and the prettier overrides to all Typescript files | ||
rules: Object.assign( | ||
typescriptEslintRecommended.rules, | ||
typescriptEslintPrettier.rules, | ||
{ | ||
'@typescript-eslint/explicit-member-accessibility': 'off', | ||
}, | ||
), | ||
}, | ||
{ | ||
files: ['example/**/*.ts', 'example/**/*.tsx'], | ||
rules: { | ||
// Turn off rules which are useless and annoying for the example files files | ||
'@typescript-eslint/explicit-function-return-type': 'off', | ||
'react-native/no-inline-styles': 'off', | ||
}, | ||
}, | ||
{ | ||
files: ['**/__tests__/**/*.ts', '**/*.spec.ts'], | ||
env: { | ||
jest: true, | ||
}, | ||
rules: { | ||
// Turn off rules which are useless and annoying for unit test files | ||
'@typescript-eslint/explicit-function-return-type': 'off', | ||
}, | ||
}, | ||
{ | ||
files: ['*.ts', '*.tsx'], | ||
rules: { | ||
'no-dupe-class-members': 'off', | ||
}, | ||
}, | ||
], | ||
}; |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
*.pbxproj -text |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
{ | ||
"trailingComma": "all", | ||
"requirePragma": true, | ||
"singleQuote": true, | ||
"arrowParens": "always" | ||
"trailingComma": "all", | ||
"bracketSpacing": false, | ||
"jsxBracketSameLine": true | ||
} |
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
# Global owners | ||
* @johan-dutoit @janicduplessis |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
# Contributing to React Native ImagePicker | ||
|
||
## Development Process | ||
All work on React Native ImagePicker happens directly on GitHub. Contributors send pull requests which go through a review process. | ||
|
||
> **Working on your first pull request?** You can learn how from this *free* series: [How to Contribute to an Open Source Project on GitHub](https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github). | ||
1. Fork the repo and create your branch from `master` (a guide on [how to fork a repository](https://help.github.com/articles/fork-a-repo/)). | ||
2. Run `yarn` or `npm install` to install all required dependencies. | ||
3. Now you are ready to make your changes! | ||
|
||
## Tests & Verifications | ||
Currently we use `TypeScript` for typechecking, `eslint` with `prettier` for linting and formatting the code, and `jest` for unit testing. | ||
|
||
* `yarn test`: Run all tests and validations. | ||
* `yarn validate:android`: Run Spotless style checker on the Java code. | ||
* `yarn validate:eslint`: Run `eslint`. | ||
* `yarn validate:eslint --fix`: Run `eslint` and automatically fix issues. This is useful for correcting code formatting. | ||
* `yarn validate:typescript`: Run `typescript` typechecking. | ||
* `yarn test:jest`: Run unit tests with `jest`. | ||
|
||
## Sending a pull request | ||
When you're sending a pull request: | ||
|
||
* Prefer small pull requests focused on one change. | ||
* Verify that all tests and validations are passing. | ||
* Follow the pull request template when opening a pull request. | ||
|
||
## Commit message convention | ||
We prefix our commit messages with one of the following to signify the kind of change: | ||
|
||
* **build**: Changes that affect the build system or external dependencies. | ||
* **ci**, **chore**: Changes to our CI configuration files and scripts. | ||
* **docs**: Documentation only changes. | ||
* **feat**: A new feature. | ||
* **fix**: A bug fix. | ||
* **perf**: A code change that improves performance. | ||
* **refactor**: A code change that neither fixes a bug nor adds a feature. | ||
* **style**: Changes that do not affect the meaning of the code. | ||
* **test**: Adding missing tests or correcting existing tests. | ||
|
||
## Release process | ||
We use [Semantic Release](http://semantic-release.org) to automatically release new versions of the library when changes are merged into master. Using the commit message convention described above, it will detect if we need to release a patch, minor, or major version of the library. | ||
|
||
## Reporting issues | ||
You can report issues on our [bug tracker](https://github.com/react-native-community/react-native-ImagePicker/issues). Please search for existing issues and follow the issue template when opening an issue. | ||
|
||
## License | ||
By contributing to React Native ImagePicker, you agree that your contributions will be licensed under the **MIT** license. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.