You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Injects arbitrary html strings through the HelmetsOpenedVisor element.
This closes#323 . See https://www.npmjs.com/package/react-helmet-with-visor . We had to make the fork and the package for our needs, but would be happy to merge back to your project.
This looks fantastic. I wish it were merged, but we need this badly so I'm giving the fork out a try for now (though like anyone just concerned about longer term maintenance of the package without a formal merge). Thanks @kokushkin !!!
any news on this?
Hi @theskillwithin , what do you mean news?) I thought the owners of the library could help me out with the tests failures (local tests were ok). But seems like they don't like the idea, isn't it @cwelch5 ? So, there is fork https://www.npmjs.com/package/react-helmet-with-visor what we're using and you might as well. And we can merge everything from here if you are missing something. BTW, I made a video https://www.youtube.com/watch?v=DWPP16LGNOA about the subject. Don't hesitate to reach me out, maybe we can hack something together 😉
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Injects arbitrary html strings through the HelmetsOpenedVisor element.
This closes #323 . See https://www.npmjs.com/package/react-helmet-with-visor . We had to make the fork and the package for our needs, but would be happy to merge back to your project.