Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix update attributes #369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tanhauhau
Copy link

  • to have helmetAttributes and attributesToRemove separately is a bit unnecessary IMHO

@codecov
Copy link

codecov bot commented Apr 15, 2018

Codecov Report

Merging #369 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
- Coverage    97.6%   97.58%   -0.02%     
==========================================
  Files           3        3              
  Lines         292      290       -2     
==========================================
- Hits          285      283       -2     
  Misses          7        7
Impacted Files Coverage Δ
src/HelmetUtils.js 96.84% <100%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c102586...3b22583. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant