Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link with rel="alternate" should be unique based on hrefLang #318

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ignatiusreza
Copy link

since it's kinda hard to add support for this within the current code base.. I refactor the implementation for deciding which key is considered the primary key a bit.. the updated code should also fix #279..

within the updated code, priority for which keys should be considered first is based on the primaryAttributes array given to getTagsFromPropsList (leftmost first).. this makes the ordering the attributes appear in user code irrelevant..

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2017

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 25, 2017

Codecov Report

Merging #318 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
+ Coverage   97.59%   97.62%   +0.03%     
==========================================
  Files           3        3              
  Lines         291      295       +4     
==========================================
+ Hits          284      288       +4     
  Misses          7        7
Impacted Files Coverage Δ
src/HelmetConstants.js 100% <ø> (ø) ⬆️
src/HelmetUtils.js 96.91% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86276f3...8289a5f. Read the comment docs.

@louisremi
Copy link

We'd be willing to send a small Amazon gift card in exchange for having this PR merged :-)

@tmbtech tmbtech requested a review from cwelch5 April 25, 2019 17:36
@vince1995
Copy link

Any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order of rel and href matters for link tags with rel="alternate"
4 participants