Check spaces in container links

[fa2k]

PR checklist

• This comment contains a description of changes (with reason)
• CHANGELOG.md is updated
• If you've fixed a bug or added code that should be tested, add tests!
• Documentation in docs is updated

This PR adds checks to see if there are spaces in the URLs used for container images - solving issue #2452 .
I'm adding tests for linting the container string, including the new check and the check for double quotes. (Similar to the tests for linting the process labels)

[Edited after merge - corrected issue number]

[mirpedrol]

It is looking good :) I added a couple of things that need fixing

[mirpedrol]

Suggested change

	- Check for spaces in container URLs ([#2452](https://github.com/nf-core/tools/issues/2452))
	- Check for spaces in modules container URLs ([#2452](https://github.com/nf-core/tools/issues/2452))

Could you move this point to the changelog for version 2.11dev above?

[mirpedrol]

This test should fail, not a warning

[mirpedrol]

Suggested change

	def test_modules_lint_check_process_labels(self):
	def test_modules_lint_check_url_spaces(self):

[mirpedrol]

This function is checking the whole process section, including other checks such as labels, etc. In order to add a test for URL spaces only, you should write this check in a separate function, which is called inside check_process_section() and use this function here in the test.

[fa2k]

Thanks for the review! I will implement those changes. It's strange that my tests still passed, even though I had specified the test cases to be warnings instead of errors like they should be. I'll double check that the new tests were actually run - and make sure they fail when they require 1 warning and 0 errors.

[codecov]

Codecov Report

Merging #2489 (3c6af2d) into dev (3fddb70) will increase coverage by 0.08%.
Report is 13 commits behind head on dev.
The diff coverage is 90.47%.

@@            Coverage Diff             @@
##              dev    #2489      +/-   ##
==========================================
+ Coverage   70.53%   70.62%   +0.08%     
==========================================
  Files          87       88       +1     
  Lines        9456     9493      +37     
==========================================
+ Hits         6670     6704      +34     
- Misses       2786     2789       +3     

Files	Coverage Δ
nf_core/modules/lint/main_nf.py	69.75% <90.47%> (+1.36%)	⬆️

... and 9 files with indirect coverage changes

[fa2k]

Those issues should now be fixed. (The subsequent force-push is a small correction to the test function name)

[mirpedrol]

LGTM thanks!