Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiny bugfixes #476

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Tiny bugfixes #476

merged 2 commits into from
Oct 14, 2024

Conversation

apeltzer
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/smrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@apeltzer apeltzer requested review from mashehu and maxulysse October 14, 2024 09:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit e5a7cc1

+| ✅ 243 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.fastp_known_mirna_adapters

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-10-14 09:11:07

mashehu
mashehu approved these changes Oct 14, 2024
View reviewed changes
CITATIONS.md Outdated Show resolved Hide resolved
@apeltzer @mashehu
Update CITATIONS.md
e5a7cc1 
Co-authored-by: Matthias Hörtenhuber <[email protected]>
@apeltzer apeltzer merged commit e7f4ffa into dev Oct 14, 2024
8 checks passed
@apeltzer apeltzer deleted the tiny-fixes branch October 14, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apeltzer @maxulysse @mashehu