Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add licences and authorship information #464

Merged
merged 2 commits into from
Oct 6, 2024
Merged

Add licences and authorship information #464

merged 2 commits into from
Oct 6, 2024

Conversation

apeltzer
Copy link
Member

@apeltzer apeltzer commented Oct 6, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/smrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 46e77be

+| ✅ 231 tests passed       |+
#| ❔   1 tests were ignored |#

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.fastp_known_mirna_adapters

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-10-06 19:26:59

@apeltzer
Copy link
Member Author

apeltzer commented Oct 6, 2024

Pinging here everyone who was in the git history of the respective two scripts in the pipeline:

@ewels @jfy133 @chuan-wang @lpantano @atrigila @kstawiski @KevinMenden @sdjebali

All of your were mentioned in the authorship section of the respective script in the bin folder. No need to get active on this, but wanted to make sure everyone is at least made aware of this 👍🏻

@apeltzer
Copy link
Member Author

apeltzer commented Oct 6, 2024

Fixed #465

@apeltzer apeltzer merged commit 2b17955 into dev Oct 6, 2024
6 checks passed
@apeltzer apeltzer deleted the licences branch October 6, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrigila atrigila atrigila approved these changes

@nschcolnicov nschcolnicov Awaiting requested review from nschcolnicov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apeltzer @atrigila