Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade multiqc and update modules #432

Merged
merged 8 commits into from
Sep 19, 2024
Merged

Upgrade multiqc and update modules #432

merged 8 commits into from
Sep 19, 2024

Conversation

atrigila
Copy link
Contributor

@atrigila atrigila commented Sep 19, 2024 •
edited
Loading

Updates MultiQC
UMIcollapse already part of MultiQC code:
image

New grouping feature only supports FastQC and cutadapt and is not applicable to our data (hairpin/mature matches obtained with samtools)

Closes #428

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/smrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit db440ff

+| ✅ 220 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.fastp_known_mirna_adapters

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-09-19 15:56:26

@atrigila atrigila marked this pull request as ready for review September 19, 2024 14:25
@atrigila atrigila marked this pull request as draft September 19, 2024 14:35
@atrigila atrigila changed the title Upgrade multiqc Upgrade multiqc and update modules Sep 19, 2024
@atrigila atrigila marked this pull request as ready for review September 19, 2024 15:57
@atrigila atrigila requested a review from apeltzer September 19, 2024 16:48
@atrigila atrigila self-assigned this Sep 19, 2024
@apeltzer apeltzer merged commit 395f801 into nf-core:dev Sep 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeltzer apeltzer apeltzer approved these changes

Assignees

@atrigila atrigila

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atrigila @apeltzer