Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edgeR_mirBase.R error #380

Merged
merged 15 commits into from
Aug 20, 2024
Merged

Fix edgeR_mirBase.R error #380

merged 15 commits into from
Aug 20, 2024

Conversation

atrigila
Copy link
Contributor

@atrigila atrigila commented Aug 19, 2024 •
edited
Loading

Fixes #187

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/smrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@atrigila atrigila self-assigned this Aug 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 19, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit e1a18e6

+| ✅ 213 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.fastp_known_mirna_adapters

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-08-20 15:56:06

@atrigila atrigila marked this pull request as ready for review August 19, 2024 15:44
nschcolnicov
nschcolnicov reviewed Aug 20, 2024
View reviewed changes
bin/edgeR_miRBase.r Outdated Show resolved Hide resolved
@atrigila atrigila requested a review from nschcolnicov August 20, 2024 16:41
nschcolnicov
nschcolnicov approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@nschcolnicov nschcolnicov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@atrigila atrigila merged commit 9d4f669 into nf-core:dev Aug 20, 2024
14 checks passed
@atrigila atrigila deleted the edgeR_mirbase branch August 20, 2024 17:58
@atrigila atrigila mentioned this pull request Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschcolnicov nschcolnicov nschcolnicov approved these changes

Assignees

@atrigila atrigila

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atrigila @nschcolnicov @robsyme @apeltzer