Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional-phred-scores #342

Merged
merged 10 commits into from
Apr 17, 2024
Merged

Optional-phred-scores #342

merged 10 commits into from
Apr 17, 2024

Conversation

apeltzer
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/smrnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @apeltzer,

It looks like this pull-request is has been made against the nf-core/smrnaseq master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/smrnaseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@apeltzer apeltzer changed the base branch from master to dev April 17, 2024 09:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit aecb218

+| ✅ 182 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.fastp_known_mirna_adapters

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-04-17 11:21:23

@apeltzer apeltzer mentioned this pull request Apr 17, 2024
Closed
@fmalmeida fmalmeida self-requested a review April 17, 2024 10:24
fmalmeida
fmalmeida approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@fmalmeida fmalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The .transpose() line is ensuring you have a combination, adapter+ID, for each read, right?

@apeltzer
Copy link
Member Author

LGTM.

The .transpose() line is ensuring you have a combination, adapter+ID, for each read, right?

Yes exactly :) Need that for mirtrace

@apeltzer
Copy link
Member Author

Some weird CI hiccups happening now :(

@apeltzer apeltzer enabled auto-merge April 17, 2024 11:20
@apeltzer apeltzer merged commit 2741a78 into dev Apr 17, 2024
10 checks passed
@apeltzer apeltzer deleted the optional-phred-scores branch April 17, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grst grst grst left review comments

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

@fmalmeida fmalmeida fmalmeida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apeltzer @grst @fmalmeida @FriederikeHanssen