-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
address reviewer comments for first release #156
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrigila
changed the title
update nf-test version
address reviewer comments for first release
Nov 5, 2024
I will continue addressing these changes tomorrow |
This reverts commit e5e4818.
The update to release date will be done once all changes are merged and reviewers approve the final release PR |
LouisLeNezet
requested changes
Nov 10, 2024
Co-authored-by: Louis LE NEZET <[email protected]>
…phaseimpute into adress_review_comments
LouisLeNezet
approved these changes
Nov 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The metro map is really nice to understand which tools are used when.
We can improve it in the future if we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address @mashehu's (thank you!!) comments from first release PR.
Readme.md
: such as ```csv title="samplesheet.csv"DEVELOPMENT.md
toCONTRIBUTING.md
. RemoveDEVELOPMENT.md
.docs/images/Logo.svg
docs/images/metro/metro.py
docs/images/metro/txt2image.md
is requiredoutput.md
: "steps".output.md
where are tsv files located.output.md
andREADME.md
.output.md
usage.md
instead of 6.usage.md
.usage.md
.groovy
in Custom Tool Arguments sectionmodules/local/*/tags.yml
nextflow.config
rename_chr
andcompute_freq
)