Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nf core template merge 3.0.1 #128

Merged
merged 12 commits into from
Oct 11, 2024
Merged

Nf core template merge 3.0.1 #128

merged 12 commits into from
Oct 11, 2024

Conversation

LouisLeNezet
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/phaseimpute branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@LouisLeNezet LouisLeNezet requested a review from atrigila October 10, 2024 21:06
atrigila
atrigila approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@atrigila atrigila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this!

@LouisLeNezet LouisLeNezet merged commit c007e41 into nf-core:dev Oct 11, 2024
11 checks passed
LouisLeNezet added a commit to LouisLeNezet/phaseimpute that referenced this pull request Oct 11, 2024
@LouisLeNezet @nf-core-bot
Nf core template merge 3.0.1 (nf-core#128)
7b2b16d 
* Template update for nf-core/tools version 3.0.0

* Template update for nf-core/tools version 3.0.1

* Update template_version_comment.yml

* Update template_version_comment.yml

* Add title to usage files

* Remove old way igenomes config

* Update main.nf and utils nf-core sbwf

* Update schema json

* Fix linting

* Update validation snap

---------

Co-authored-by: nf-core-bot <[email protected]>
@LouisLeNezet LouisLeNezet self-assigned this Oct 29, 2024
@LouisLeNezet LouisLeNezet added the enhancement New feature or request label Oct 29, 2024
@LouisLeNezet LouisLeNezet added this to the v0.99.0 milestone Oct 29, 2024
@LouisLeNezet LouisLeNezet deleted the nf-core-template-merge-3.0.1 branch November 18, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrigila atrigila atrigila approved these changes

Assignees

@LouisLeNezet LouisLeNezet

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.99.0
Development

Successfully merging this pull request may close these issues.
3 participants
@LouisLeNezet @atrigila @nf-core-bot