Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit downloads #95

Merged
merged 2 commits into from
Nov 22, 2024
Merged

fix: limit downloads #95

merged 2 commits into from
Nov 22, 2024

Conversation

znorgaard
Copy link
Collaborator

@znorgaard znorgaard commented Nov 18, 2024

There's a bug in the pipelines download command which is resolved with the limiting to a single concurrent download.

Manual run of the integration test for this branch passes!
https://github.com/nf-core/fastquorum/actions/runs/11903116704/job/33170144108

I also set a planned release date for Friday 2024-11-22. Which will give us time to merge this PR and get a second review.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/fastquorum branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

github-actions bot commented Nov 18, 2024

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 0ae6de5

+| ✅ 193 tests passed       |+
#| ❔   8 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-11-19 16:04:12

@znorgaard znorgaard marked this pull request as ready for review November 19, 2024 16:01
@znorgaard znorgaard merged commit 78778df into dev Nov 22, 2024
9 checks passed
@znorgaard znorgaard deleted the zn_download branch November 22, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants