Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: Enhance error handling in trace module #340

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GarmashAlex
Copy link

Are there existing issue(s) that this PR would close?

No

Describe your changes.

  • Replace panic-inducing expect() calls with proper error propagation
  • Add Result return types to functions that could fail
  • Fix debug logging placement for unsupported instructions
  • Improve code structure and error handling consistency
  • Add InvalidMemoryState error variant for better error reporting

These changes make the code more robust and maintainable by properly
handling potential errors instead of panicking, while also fixing the
placement of debug logging to ensure it works as intended.

@sjudson
Copy link
Contributor

sjudson commented Jan 8, 2025

Thanks for the PR.

Right now the Jolt integration is in an experimental state, and the API will likely be significantly redesigned as we look to more robustly integrate it as a first-class proving backend within our codebase. For the moment then we'll likely not accept a PR updating it, but that may change as we make future improvements so I'll leave this PR open accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants