Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] 66 Resolve Build Warnings #109

Merged
merged 4 commits into from
Jun 20, 2024
Merged

[Refactor] 66 Resolve Build Warnings #109

merged 4 commits into from
Jun 20, 2024

Conversation

Conundraah
Copy link
Contributor

@Conundraah Conundraah commented Jun 19, 2024 •
edited
Loading

  • fixed a build warning in src/Nexus.UI/Charts/Chart.razor.cs
  • fixed a build warning in src/Nexus.UI/Controls/UIAutocomplete.razor
  • fixed a build warning in src/Nexus.UI/Controls/UIContextMenu.razor
  • fixed a build warning in src/Nexus.UI/Controls/UIDatePicker.razor
  • fixed a build warning in src/Nexus.UI/Controls/UIOption.razor
  • fixed a build warning in src/Nexus.UI/Core/PeriodConverter.cs
  • fixed a build warning in src/Nexus.UI/Nexus.UI.csproj
  • fixed a build warning in src/Nexus.UI/Pages/Index.razor
  • fixed a build warning in src/extensibility/dotnet-extensibility/DataModel/Resource.cs
  • fixed a build warning in src/extensibility/dotnet-extensibility/DataModel/ResourceCatalog.cs

closes #36

[Refactor] 66 Resolve Build Warnings
395ba5e 
- fixed multiple build warnings
@Conundraah Conundraah requested a review from Apollo3zehn June 19, 2024 12:47
@Conundraah Conundraah self-assigned this Jun 19, 2024
@Conundraah Conundraah linked an issue Jun 19, 2024 that may be closed by this pull request
Resolve build warnings #66
Closed
Timo Schauties added 2 commits June 20, 2024 07:50
[Refactor] 66 Resolve Build Warnings
071ccb4 
- reverted a change from a debugging session
[Refactor] 66 Resolve Build Warnings
a6d5f9b 
- updated openapi.json
Apollo3zehn
Apollo3zehn requested changes Jun 20, 2024
View reviewed changes
src/Nexus.UI/Charts/Chart.razor.cs Outdated Show resolved Hide resolved
src/Nexus.UI/Controls/UIDatePicker.razor Outdated Show resolved Hide resolved
src/extensibility/dotnet-extensibility/DataModel/ResourceCatalog.cs Outdated Show resolved Hide resolved
src/Nexus.UI/Controls/UIContextMenu.razor Show resolved Hide resolved
src/Nexus.UI/Controls/UIDatePicker.razor Show resolved Hide resolved
[Refactor] 66 Resolve Build Warnings
85a4a8f 
- added code review changes
@Conundraah Conundraah merged commit 5acb50d into dev Jun 20, 2024
3 checks passed
@Conundraah Conundraah deleted the 66-resolve-build-warnings branch June 20, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apollo3zehn Apollo3zehn Apollo3zehn approved these changes

Assignees

@Conundraah Conundraah

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Conundraah @Apollo3zehn