Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove cursor-hit in hiddenInputClasses #4474

Open
wants to merge 2 commits into
base: canary
Choose a base branch
from

Conversation

Layouwen
Copy link

@Layouwen Layouwen commented Dec 31, 2024

Closes #4473

📝 Description

cursor hit will cause the overflow scrollbar to overflow abnormally under overflow-auto.

⛳️ Current behavior (updates)

e536aaf5dfd9b25a1070ceb522563c9
a17df08f2e45bee6ba417e8e84af3b3

92ed33ce13fe750a8e4294c372f6ba3
d42eeffc83da567afcf10223e2062f9

🚀 New behavior

cancel hit area

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Summary by CodeRabbit

  • Style
    • Simplified hidden input classes configuration.
    • Updated width handling for hidden input elements to 100%.
    • Removed custom cursor hit area positioning logic.

Copy link

changeset-bot bot commented Dec 31, 2024

🦋 Changeset detected

Latest commit: 14d0521

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@nextui-org/theme Patch
@nextui-org/autocomplete Patch
@nextui-org/checkbox Patch
@nextui-org/date-input Patch
@nextui-org/date-picker Patch
@nextui-org/form Patch
@nextui-org/input-otp Patch
@nextui-org/input Patch
@nextui-org/radio Patch
@nextui-org/select Patch
@nextui-org/table Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 31, 2024

@Layouwen is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Dec 31, 2024

Walkthrough

The pull request modifies the hiddenInputClasses array in the packages/core/theme/src/utils/classes.ts file. The changes involve removing three lines related to CSS variable declarations for cursor hit area adjustments and replacing them with a single class "w-full". This simplifies the handling of input width and positioning, which may address layout issues with input elements in the Switch component.

Changes

File Change Summary
packages/core/theme/src/utils/classes.ts Removed CSS variable declarations for cursor hit area and replaced specific positioning classes with "w-full"
.changeset/lazy-ants-exercise.md Added patch for @nextui-org/theme and refactored hiddenInputClasses

Assessment against linked issues

Objective Addressed Explanation
Fix width overflow in Switch component [#4473]

Possibly related PRs

Suggested labels

👀 Status: In Review

Suggested reviewers

  • wingkwong
  • jrgarciadev

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bc5a4e0 and 14d0521.

📒 Files selected for processing (1)
  • .changeset/lazy-ants-exercise.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .changeset/lazy-ants-exercise.md

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add changeset.

@Layouwen
Copy link
Author

Layouwen commented Jan 1, 2025

please add changeset.

Please help me to see if it's correct

@Layouwen Layouwen requested a review from wingkwong January 1, 2025 08:12
@jrgarciadev
Copy link
Member

@wingkwong please check the checkbox with label behavior

@wingkwong wingkwong self-assigned this Jan 3, 2025
@wingkwong wingkwong added this to the v2.6.12 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Input width double in Switch causes flex layout exception.
3 participants